Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel 1.0.0 Compatibility #862

Closed
thundergolfer opened this issue Oct 12, 2019 · 2 comments
Closed

Bazel 1.0.0 Compatibility #862

thundergolfer opened this issue Oct 12, 2019 · 2 comments

Comments

@thundergolfer
Copy link
Contributor

Description

Bumping rules_scala to current HEAD, f985e5e0d6364970be8d6f15d262c8b0e0973d1b, allowed me to build a very minimal amount of Scala code (in thundergolfer/the-one-true-bazel-monorepo) using Bazel 1.0.0. Reassuring, but hardly a proper test of compatibility.

The README currently doesn't list 1.0.0 in its compatibility table, so I'm opening this issue to highlight that and track 1.0.0 compatibility.

Thanks for all the work on these rules. Hopefully I can contribute back someday 🙂.
@johnynek
Copy link
Member

See #861 — all tests pass.

Why not send your first PR as a note in the README that 1.0 is supported?

@thundergolfer thundergolfer mentioned this issue Oct 13, 2019
Merged
@ittaiz
Copy link
Member

ittaiz commented Jan 17, 2020

readme is updated. We're using bazel 2.0 and rules_scala on prod

@ittaiz ittaiz closed this as completed Jan 17, 2020
gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this issue May 31, 2022
@ollin @Godin
Add validation test for groovy.transform.Immutable (bazelbuild#862)
120675c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnynek @ittaiz @thundergolfer