-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowlist more clang flags in bindgen #2902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlopko
force-pushed
the
dont_filter_clang
branch
3 times, most recently
from
September 26, 2024 10:18
6bab722
to
961a48a
Compare
could you look into the failing CI? Looks related. |
krasimirgg
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just marking as needs attn)
hlopko
force-pushed
the
dont_filter_clang
branch
from
September 26, 2024 12:59
961a48a
to
7d22cbc
Compare
hlopko
force-pushed
the
dont_filter_clang
branch
from
September 30, 2024 18:01
7d22cbc
to
142cc22
Compare
The CI is green now, thanks for the ping! |
krasimirgg
approved these changes
Oct 1, 2024
zemnmez-renovate-bot
added a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 4, 2024
##### [`v0.52.0](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.0) ### 0.52.0 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.52.0") ``` #### WORKSPACE ```python load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-eTHntUQQe2ICm/L8cuefnXdSOtZQ1ELZPD/M6a1ewes=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.0/rules_rust-v0.52.0.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Allowlist more clang flags in bindgen by [@hlopko](https://github.com/hlopko) in bazelbuild/rules_rust#2902 - Allow `+` in repo names by [@fmeum](https://github.com/fmeum) in bazelbuild/rules_rust#2908 - Added utility for parsing action Args param files by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2897 - Updated platform triple mapping to support T3 platforms without `std`. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2899 - Fix `override_targets` keys in docs by [@max-heller](https://github.com/max-heller) in bazelbuild/rules_rust#2905 - Use absolute path with "-fsanitize-ignorelist" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2911 - Fix platform validation for wasm32-wasip1 target by [@c16a](https://github.com/c16a) in bazelbuild/rules_rust#2894 - Update `cargo_build_script` to always render custom runfiles dirs. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2891 - Check target tags before ignore tags for lint/fmt aspects by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2913 - Get rolling releases CI green by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2916 - Avoid uses of shell to improve Windows tests by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2912 - Prep release 0.52.0 by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2910 #### New Contributors - [@fmeum](https://github.com/fmeum) made their first contribution in bazelbuild/rules_rust#2908 - [@max-heller](https://github.com/max-heller) made their first contribution in bazelbuild/rules_rust#2905 - [@vitalybuka](https://github.com/vitalybuka) made their first contribution in bazelbuild/rules_rust#2911 - [@c16a](https://github.com/c16a) made their first contribution in bazelbuild/rules_rust#2894 **Full Changelog**: bazelbuild/rules_rust@0.51.0...0.52.0
github-merge-queue bot
pushed a commit
to zemn-me/monorepo
that referenced
this pull request
Oct 4, 2024
##### [`v0.52.0](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.0) ### 0.52.0 #### Bzlmod ```python bazel_dep(name = "rules_rust", version = "0.52.0") ``` #### WORKSPACE ```python load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_rust", integrity = "sha256-eTHntUQQe2ICm/L8cuefnXdSOtZQ1ELZPD/M6a1ewes=", urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.0/rules_rust-v0.52.0.tar.gz"], ) ``` Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup #### What's Changed - Allowlist more clang flags in bindgen by [@hlopko](https://github.com/hlopko) in bazelbuild/rules_rust#2902 - Allow `+` in repo names by [@fmeum](https://github.com/fmeum) in bazelbuild/rules_rust#2908 - Added utility for parsing action Args param files by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2897 - Updated platform triple mapping to support T3 platforms without `std`. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2899 - Fix `override_targets` keys in docs by [@max-heller](https://github.com/max-heller) in bazelbuild/rules_rust#2905 - Use absolute path with "-fsanitize-ignorelist" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2911 - Fix platform validation for wasm32-wasip1 target by [@c16a](https://github.com/c16a) in bazelbuild/rules_rust#2894 - Update `cargo_build_script` to always render custom runfiles dirs. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2891 - Check target tags before ignore tags for lint/fmt aspects by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2913 - Get rolling releases CI green by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2916 - Avoid uses of shell to improve Windows tests by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2912 - Prep release 0.52.0 by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2910 #### New Contributors - [@fmeum](https://github.com/fmeum) made their first contribution in bazelbuild/rules_rust#2908 - [@max-heller](https://github.com/max-heller) made their first contribution in bazelbuild/rules_rust#2905 - [@vitalybuka](https://github.com/vitalybuka) made their first contribution in bazelbuild/rules_rust#2911 - [@c16a](https://github.com/c16a) made their first contribution in bazelbuild/rules_rust#2894 **Full Changelog**: bazelbuild/rules_rust@0.51.0...0.52.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially
--target
is very usable for cross-compilation use cases.