Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo_build_script to always render custom runfiles dirs. #2891

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Update cargo_build_script to always render custom runfiles dirs. #2891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9a35c22
Update `cargo_build_script` to always render custom runfiles dirs.
UebelAndre Sep 20, 2024
22247c8
Merge branch 'main' into cargo_runfiles
UebelAndre Oct 2, 2024
eb8ae5e
Smaller runfiles directories
UebelAndre Oct 2, 2024
1b310be
Merge branch 'main' into cargo_runfiles
UebelAndre Oct 3, 2024
77c8e26
poke
UebelAndre Oct 3, 2024
e041d9b
Update cargo/cargo_build_script_runner/bin.rs
UebelAndre Oct 3, 2024
ab9b6e8
PR feedback
UebelAndre Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,10 @@ tasks:
platform: windows
build_flags:
- "--noenable_runfiles"
- "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
test_flags:
- "--noenable_runfiles"
- "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
build_targets: *default_windows_no_runfiles_targets
test_targets: *default_windows_no_runfiles_targets
ubuntu2004_split_coverage_postprocessing:
Expand Down Expand Up @@ -202,10 +204,12 @@ tasks:
- "--noenable_runfiles"
- "--config=rustfmt"
- "--config=clippy"
- "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
test_flags:
- "--noenable_runfiles"
- "--config=rustfmt"
- "--config=clippy"
- "--//cargo/settings:incompatible_runfiles_cargo_manifest_dir=true"
build_targets: *default_windows_no_runfiles_targets
test_targets: *default_windows_no_runfiles_targets
windows_rolling_with_aspects:
Expand Down Expand Up @@ -647,7 +651,7 @@ tasks:
environment:
# This ndk version matches with rules_android_ndk repo's CI
# https://github.com/bazelbuild/rules_android_ndk/blob/877c68ef34c9f3353028bf490d269230c1990483/.bazelci/presubmit.yml#L37
# The ndk is installed by this script
# The ndk is installed by this script
# https://github.com/bazelbuild/continuous-integration/blob/ba56013373821feadd9f2eaa6b81eb19528795f0/macos/mac-android.sh
ANDROID_NDK_HOME: /opt/android-ndk-r25b
android_examples_macos:
Expand All @@ -662,7 +666,7 @@ tasks:
environment:
# This ndk version matches with rules_android_ndk repo's CI
# https://github.com/bazelbuild/rules_android_ndk/blob/877c68ef34c9f3353028bf490d269230c1990483/.bazelci/presubmit.yml#L42
# The ndk is installed by this script
# The ndk is installed by this script
# https://github.com/bazelbuild/continuous-integration/blob/ba56013373821feadd9f2eaa6b81eb19528795f0/macos/mac-android.sh
ANDROID_NDK_HOME: /Users/buildkite/android-ndk-r25b
ios_examples:
Expand Down
Loading
Loading