-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to mirror github releases to bazel central registry #2256
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
815c1a4
to
44cc169
Compare
@@ -0,0 +1,3 @@ | |||
fixedReleaser: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workaround for this issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Do you know what would be required in also uploading cargo-bazel
binaries?
Im not sure. I tried to look in the docs/bcr source but was not able to find anything regarding uploading binaries separately so far |
@kageiit we've since done release 0.31.0 but I don't think I see any change in https://github.com/bazelbuild/bazel-central-registry. Did this PR have the intended effect? |
I believe the repo maintainers have to give access to the github app to listen to the relevant webhooks. I added a link to it in the PR description - https://github.com/apps/publish-to-bcr . @UebelAndre you will have to install the app for the changes to take effect |
I unfortunately don't know anything about Github apps. Maybe @scentini can take a look since they're an admin of the repo? |
@UebelAndre Under the How it works section for After that, we will need someone at Google to enable the |
I already enabled the |
@scentini Thanks! @UebelAndre I believe that the fork is the last piece of the puzzle. Once that is ready, we should be able to create a release and see a PR in the BCR. 🤞 |
@scentini I think it'd be best if you (or some Googler) made the fork. Would you mind making one? |
@scentini Thank you for setting up the fork and making yourself the |
Rules_rust 0.33.0 was recently released and I don't see anything having happened in bazel-central-registry. Does something need to be done on their end regarding bazelbuild/bazel-central-registry#329? |
I thought that we had all of our ducks lined up. I will investigate. |
It worked for 0.34.1. bazelbuild/bazel-central-registry#1199 |
Sweet. Unfortunately, the presubmit is failing. I should be able to investigate on Monday. |
Add machinery to automatically push GitHub releases to bazel central registry. This will need some setup by the ruleset maintainers to enable the GitHub app when bzlmod support is ready. See the instructions for more details
Ref #2181