Updated min tested Bazel version to 4.0.0 #533
Conversation
UebelAndre
requested review from
andyscott and
thundergolfer
as code owners
There was a problem hiding this comment.
I'm +1 on this, will wait for @alexeagle stamp as well. How risky is this upgrade, it may make future releases incompatible for people who can't go to newer bazel version right?
|
We'll need to document this as a breaking change, that users must upgrade to 4.0. We'll start using new features like the One thing to figure out (maybe before merging this?) is how to give the right error message so developers know they must upgrade, instead of just reporting name 'json' is not defined |
|
I unfortunately don't have a whole lot of bandwidth so don't think I'll be able to get to that in the near future 😞 Is this something I can leave to the |
|
I think I could find time for it. I'm looking around for where the check could go - there's no single call from users WORKSPACE files into a repository rule that we could put it. So I guess we just check at the beginning of several of them like |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
Since we only test against bazel 4.0 now, and will start using features that require it, this gives users an obvious error message that they need to update.
| @@ -3,6 +3,9 @@ | |||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | |||
| load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe") | |||
|
|
|||
| # Avoid a load from @bazel_skylib repository as users don't necessarily have it installed | |||
There was a problem hiding this comment.
Looks like versions.bzl tries to load skylib anyway. https://github.com/bazelbuild/rules_python/pull/533/files#diff-86c5bb17276af4fdb85612635eabfdaf9b91676ae6bac37ee78a09947dfd6045R1
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #526
What is the new behavior?
Updates the min tested Bazel version to
4.0.0Does this PR introduce a breaking change?
Other information
closes #526