Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty requirements.txt #38

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Handle empty requirements.txt #38

merged 1 commit into from
Nov 13, 2017

Conversation

hwright
Copy link
Contributor

@hwright hwright commented Nov 13, 2017

Fixes #36

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@mattmoor mattmoor self-requested a review November 13, 2017 17:18
@mattmoor
Copy link
Contributor

Test this please

@mattmoor mattmoor merged commit 49a434b into bazelbuild:master Nov 13, 2017
@hwright
Copy link
Contributor Author

hwright commented Nov 13, 2017

Tested it locally (can't tell if the comment was for me or a bot).

@mattmoor
Copy link
Contributor

Bot :)

@hwright hwright deleted the empty-requirements branch November 13, 2017 18:31
alexeagle pushed a commit to alexeagle/rules_python that referenced this pull request Aug 19, 2020
@dillon-giacoppo
bazelbuild#38: Add enable_implicit_namespace_pkgs (bazelbuild#55)
275995e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hwright @bazel-io @mattmoor @googlebot