fix(pip.parse): allow absolute path for python_interpreter; skip hermetic toolchain lookup when used #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uire hermetic toolchain of matching version The `python_interpreter` arg wasn't being properly handled in the bzlmod code in two ways. 1. Lookup of a hermetic runtime wasn't being skipped when it was set. The net effect was a hermetic toolchain of a matching version had to be registered, even if it wasn't used. To fix, add a check for python_interpreter to the guard of the lookup. 2. Specifying an absolute path for the value wasn't being converted to a `path` object, which meant a plain string eventually made its way to some code expecting a `path` object. To fix, call `repository_ctx.path()` on the path to convert it to a path object. Fixes bazelbuild#1618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
python_interpreterarg wasn't being properly handled in the bzlmod code in two ways.Lookup of a hermetic runtime wasn't being skipped when it was set. The net effect was it
ignored the specified interpreter and would try to lookup a hermetic interpreter using
the python version. To fix, add a check for python_interpreter to the guard of the lookup.
Specifying an absolute path for the value wasn't being converted to a
pathobject,which meant a plain string eventually made its way to some code expecting a
pathobject. To fix, call
repository_ctx.path()on the path to convert it to a path object.Fixes #1618