Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create all_data_requirements alias #1292

Merged
merged 5 commits into from
Jul 11, 2023
Merged

feat: Create all_data_requirements alias #1292

merged 5 commits into from
Jul 11, 2023

Conversation

kevinpark1217
Copy link
Contributor

@kevinpark1217 kevinpark1217 commented Jul 3, 2023

Minor change.

I am creating a Python virtualenv with Bazel, and having all_data_requirements for data dependencies just like all_requirements would be very helpful.

@kevinpark1217 kevinpark1217 requested a review from hrfuller as a code owner July 3, 2023 23:22
@google-cla
Copy link

google-cla bot commented Jul 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kevinpark1217 kevinpark1217 changed the title Create all_data_requirements alias feat: Create all_data_requirements alias Jul 3, 2023
@kevinpark1217 kevinpark1217 requested a review from rickeylev as a code owner July 3, 2023 23:42
@kevinpark1217
Copy link
Contributor Author

Hello @hrfuller @rickeylev, can I get a review?

@chrislovecnm
Copy link
Collaborator

chrislovecnm commented Jul 10, 2023

How can we test this? Can we add something to one of our examples?

@kevinpark1217
Copy link
Contributor Author

kevinpark1217 commented Jul 10, 2023

How can we test this? Can we add something to one of our examples?

Hi @chrislovecnm, I added a build_test() under examples/bzlmod. Also, examples/pip_parse_vendored/requirements.bzl shows the generated output.

Copy link
Collaborator

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if you could add some documentation in the examples, that would rock!

@chrislovecnm chrislovecnm added this pull request to the merge queue Jul 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2023
@chrislovecnm chrislovecnm added this pull request to the merge queue Jul 11, 2023
Merged via the queue into bazelbuild:main with commit 3608207 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants