Pass cpp flags through in all cases to repository rule compilations #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
force-pushed
the
be-less-cautious
branch
from
cb9978d to
52be97f
Compare
shs96c
changed the title
|
I'm not particularly concerned with reproducing and testing the bug you faced here, as we have plans to move away from building wheels in repository rules. If you think a bit about it, this is a poor's man toolchain resolution to get flags, etc. It just doesn't play well with what Bazel expects overall. |
f0rmiga
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Bugfix
What is the current behavior?
When using a layer of indirection to refer to a hermetic toolchain, python deps that compile local code fail to properly set the path to the local XCode install, causing compilation to fail (eg. when compiling
lxml's deps)What is the new behavior?
The CPP_FLAGS are set properly, and
lxmlwill install from a repository rule cleanlyDoes this PR introduce a breaking change?
No
Other information
I'm not entirely sure how to reproduce this with a test in this repo. It only showed up when we had some particularly gnarly setup with a repo at work.