Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generation of pyi files with py_proto_library #1293

Closed
bluec0re opened this issue Jul 4, 2023 · 2 comments · Fixed by #1933
Closed

Support generation of pyi files with py_proto_library #1293

bluec0re opened this issue Jul 4, 2023 · 2 comments · Fixed by #1933
Labels
help wanted

Comments

@bluec0re
Copy link

bluec0re commented Jul 4, 2023

🚀 feature request

Relevant Rules

New feature for py_proto_library

Description

protoc v3.20 and above supports to generate .pyi files from protos. Whould be great if py_proto_library would/could generate those as well by using the --pyi_out argument to protoc.

Describe the solution you'd like

A new attribute for py_proto_library to enable/disable the generation of .pyi files and a way to reference them for packaging/editor support.

Describe alternatives you've considered

Switching to https://github.com/grpc/grpc (which has added support here: grpc/grpc#32872), but we don't use grpc and would prefer to stick to primary bazel rules.
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Dec 31, 2023
@bluec0re
Copy link
Author

friendly ping

@aignas aignas added help wanted and removed Can Close? Will close in 30 days if there is no new activity labels Jan 1, 2024
@aignas aignas mentioned this issue Jun 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 5, 2024
@comius
feat: Upgrade to protobuf 27.0 and remove py_proto_library (#1933)
d0e25cf 
Protobuf team is taking ownership of `py_proto_library` and the
implementation was moved to protobuf repository.

Remove py_proto_library from rules_python, to prevent divergent
implementations.

Make a redirect with a deprecation warning, so that this doesn't break
any users.

Expected side effect of this change is also that the protobuf version is
sufficiently updated that there is no more use of legacy struct
providers.

Closes #1935 
Closes #1924 
Closes #1925 
Closes #1703 
Closes #1707 
Closes #1597 
Closes #1293 
Closes #1080
Fixes #1438
@bluec0re bluec0re mentioned this issue Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Upgrade to protobuf 27.0 and remove py_proto_library comius/rules_python
2 participants
@aignas @bluec0re