fix: _which_unchecked: don't watch PATH if binary exists.

Fixes #2551.
bazelbuild · Jan 8, 2025 · ee46291 · ee46291
1 parent 4e95a60
commit ee46291
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/python/private/repo_utils.bzl b/python/private/repo_utils.bzl
@@ -256,7 +256,7 @@ def _which_checked(mrctx, binary_name):
 def _which_unchecked(mrctx, binary_name):
     """Tests to see if a binary exists.
 
-    This is also watch the `PATH` environment variable.
+    Watches the `PATH` environment variable if the binary doesn't exist.
 
     Args:
         binary_name: name of the binary to find.
@@ -268,12 +268,12 @@ def _which_unchecked(mrctx, binary_name):
         * `describe_failure`: `Callable | None`; takes no args. If the
           binary couldn't be found, provides a detailed error description.
     """
-    path = _getenv(mrctx, "PATH", "")
     binary = mrctx.which(binary_name)
     if binary:
         _watch(mrctx, binary)
         describe_failure = None
     else:
+        path = _getenv(mrctx, "PATH", "")
         describe_failure = lambda: _which_describe_failure(binary_name, path)
 
     return struct(