Ensure that KSP-generated META-INF services included in output jar #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarr21
force-pushed
the
jb/auto-service-fix
branch
from
71ec040 to
96006ac
Compare
Bencodes
reviewed
Jul 28, 2023
| /** | ||
| * Copy generated resources from KSP task into generated folder | ||
| */ | ||
| private fun Iterator<String>.copyServicesToGenClasses(directories: Directories): Iterator<String> { |
There was a problem hiding this comment.
Thanks for putting this pull request up! Are you able to add a test case or two so that this doesn’t regress in the future?
There was a problem hiding this comment.
Proguard files are also missing (added #991 (comment)), would it make sense to include every dir from MANIFEST_DIR instead of just SERVICES_DIR?
There was a problem hiding this comment.
Yes, it would.
It's hard enough to figure out what the plugins are doing, otherwise.
There was a problem hiding this comment.
would be an easy change then right? just remove the if ("/$SERVICES_DIR" in it) ? or will it contain files we don't want ?
|
superseded by #1094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #991