Implement Jdeps using K2 APIs #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarr21
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
|
This generally looks fine, but I would prefer to wait until the dependencies are out of RC. Additionally, we have some concerns about backwards compatibility -- I am looking to setup several older version test for our CI. |
|
@jbarr21 Kotlin 2.0 is officially out, are you able to push this PR forward using the official release? |
Bencodes
reviewed
Aug 15, 2024
| class ClassUsageRecorder( | ||
| internal val explicitClassesCanonicalPaths: MutableSet<String> = mutableSetOf(), | ||
| internal val implicitClassesCanonicalPaths: MutableSet<String> = mutableSetOf(), | ||
| private val seen: MutableSet<ClassId> = mutableSetOf(), |
There was a problem hiding this comment.
This seems to be unused, is that intentional?
Bencodes
approved these changes
Aug 16, 2024
|
I was able to get an app building within our Android repo using this PR and the K2 Jdps implementation, so we should be good to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the kotlin_rules to Kotlin 2.0.0 & adds support for running Jdeps when compiling with K2 (#843).
High level list of changes:
JdepsGenExtension2which leveragesFirAdditionalCheckersplugin extension to collect info from the FIR treeClassUsageRecorderto manage collection of AST infoClassUsageRecorderis init in the registrar & dumped to a proto on theClassFileFactoryFinalizerExtensioncallback since there is no longer aonAnalysisCompletedcallback in K2FirClassSymbol,FirTypeRef, &ConeKotlinTypewhich is then pushed into theClassUsageRecorderso that supertypes & type args can also be collected, if necessaryJdepsGenComponentRegistrarto invoke K1 or K2 impl based on language version set in the kotlinc configuration