-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Jdeps extension for K2 implementation #1164
Conversation
3f251ba
to
94dfa6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take a look at the KtLint errors?
@Bencodes already fixed. the test failure passes locally though. any thoughts?
|
Ah this one is flaky. Should be good to merge. |
) : | ||
AnalysisHandlerExtension, StorageComponentContainerContributor { | ||
configuration: CompilerConfiguration, | ||
) : BaseJdepsGenExtension(configuration), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this needs to be a base class and not just some independent class that both implementations can call into?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either one works, but I figured I was going to use a common base for the 2 extensions anyways
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
* Fix K2 jdeps test args * Sort Deps in jdeps * Refactor jdeps extension to prepare for K2 impl
This PR makes 3 small changes to the JDeps extension in preparation of adding the K2 impl (#843):
KotlinJvmTestBuilder.java
. We also avoid resetting the option by modifying the existing infoBuilder instead of usingCompilationTaskInfo.newBuilder()
.deps
in the proto so that we can properly assert their equality.JdepsGenExtension
into a new base class that can be extended by the K2 implementation. There are no logic changes in this refactor.