-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use maven lock-file #1134
Use maven lock-file #1134
Conversation
Not sure where this error comes from in the failed check. Seems unrelated.
|
You might need to downgrade rules_jvm_external and file an issue upstream for this one. |
I'm not sure what to report. I guess |
Indeed, |
@scaiper can your rebase this branch? I bumped the rules Bazel version to 7.1.0 to see if that helps with compat. |
Version 7.0.2 is fine. Problem is with this test https://buildkite.com/bazel/rules-kotlin-kotlin/builds/4060#018e4350-c427-4f5d-a54f-4a7ef3c694b1
|
At the moment we try to keep compatibility with 5.x, 6.x, and 7.x https://github.com/bazelbuild/rules_kotlin?tab=readme-ov-file#rules_kotlin-bazel-compatibility Something that's odd is this example test shouldn't even be using Bzlmod https://github.com/bazelbuild/rules_kotlin/blob/be6fb59f169ac6e1dcbf395c325462343a68214b/.bazelci/presubmit.yml#L59C3-L67 |
Shouldn't the flag |
This reverts commit e3aebfe.
It's I've managed to make it work using current versions of dependencies, so I've reverted version bump. |
This PR enables use of a lock-file for
kotlin_rules_maven
repo. This in turn enables caching and reproducible builds.Had to bump
rules_jvm_external
to 6.0 and some of its transitive deps.