[testing] Switch to junit5 #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tests for modern jvms.
restingbull
requested review from
ahumesky,
cgruber,
Bencodes and
nkoroste
as code owners
Bencodes
reviewed
Mar 12, 2024
| @@ -344,6 +344,10 @@ Setup a simple kotlin_test. | |||
| default = Label("@bazel_tools//tools/jdk:TestRunner_deploy.jar"), | |||
| allow_files = True, | |||
| ), | |||
| "use_testrunner": attr.bool( | |||
There was a problem hiding this comment.
What exactly is this flag solving for and when would you use it externally vs. setting it to False?
There was a problem hiding this comment.
It matches java_test.use_testrunner. It allows customizing the test execution environment. In this case, we replace the bazel test runner with JUnit5.
Bencodes
reviewed
Mar 12, 2024
Bencodes
approved these changes
Mar 13, 2024
restingbull
added a commit
that referenced
this pull request
Mar 15, 2024
* [testing] Switch to junit5 Fixes tests for modern jvms. * Fix docs, remove jcenter, add security manager disable * fix java security manager * back out of trying to fix security manager * fix docs
restingbull
added a commit
that referenced
this pull request
Mar 15, 2024
* [testing] Switch to junit5 Fixes tests for modern jvms. * Fix docs, remove jcenter, add security manager disable * fix java security manager * back out of trying to fix security manager * fix docs
restingbull
added a commit
that referenced
this pull request
Mar 22, 2024
This reverts commit 60e1636.
restingbull
added a commit
that referenced
this pull request
Mar 24, 2024
This reverts commit 60e1636.
restingbull
added a commit
that referenced
this pull request
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests for modern jvms.