WIP: Fix missing jdeps by consistently using collectTypeReferences

[scosenza]

Problem

Kotlin jdeps are missing in some cases which is preventing Airbnb from enabling certain compile-time pruning optimizations in our fork of the IntelliJ Bazel Plugin. For example, in the below repro case, Airbnb's IntelliJ Bazel Plugin compile time pruning drops the jar containing Base which results in the following compilation error:

 Kotlin: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
        class something.ReferencesClassWithSuperClass, unresolved supertypes: something.Base

Without the change in this PR, ReferencesClassWithSuperClass has a missing jdep on superclass Base:

open class Base

class Derived : Base() {
  fun hi(): String {
    return "Hello"
  }
}

class ReferencesClassWithSuperClass {
    fun stuff(): String {
        return Derived().hi()
    }
}

Solution

Use collectTypeReferences instead of directly calling addImplicitDep or addExplicitDep as collectTypeReferences additionally always adds superclasses as implicit deps.

Note that the initial fix originally caused two existing test cases to fail:

1) function call return type[enableK2Compiler=false](io.bazel.kotlin.builder.tasks.jvm.KotlinBuilderJvmJdepsTest)
io.bazel.kotlin.builder.toolchain.CompilationStatusException: compile phase failed:
error: supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class something.SomeType, unresolved supertypes: something.SomeSuperType
Adding -Xextended-compiler-checks argument might provide additional information.

        at io.bazel.kotlin.builder.toolchain.CompilationTaskContext.executeCompilerTask(CompilationTaskContext.kt:135)

This existing test failure seems related to both:

• Example to repro jdeps issue  #855
• https://youtrack.jetbrains.com/issue/KT-44583

To fix this test, I added c.addTransitiveDependencies(depWithReturnTypesSuperType) as SomeSuperType is required to compile ReferencesClassWithSuperClass.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[scosenza]

TODO: Rename test case and add additional tests

[scosenza]

Replaced this PR with #1045