Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unbound variable when running container_image targets #2008

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix unbound variable when running container_image targets #2008

merged 1 commit into from
Jan 20, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Jan 20, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently running something like the following produces an error container_args[@]: unbound variable

bazel run //tests/container/python3:py3_image -- --rm -it --entrypoint /bin/bash

Issue Number: This is a minor bugfix to #1957

What is the new behavior?

This fixes the issue and I'm able to run my container and start a bash shell based on the arguments above.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre marked this pull request as ready for review January 20, 2022 02:41
@alexeagle alexeagle merged commit 3f0cd4b into bazelbuild:master Jan 20, 2022
@UebelAndre UebelAndre deleted the run branch January 20, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@gravypod gravypod Awaiting requested review from gravypod gravypod is a code owner

@pcj pcj Awaiting requested review from pcj pcj is a code owner

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @alexeagle