Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BazelCI breakage due to java8 library desugaring issue in bazel #122

Open
ted-xie opened this issue Aug 3, 2023 · 0 comments
Open

BazelCI breakage due to java8 library desugaring issue in bazel #122

ted-xie opened this issue Aug 3, 2023 · 0 comments
Assignees
@ted-xie

Comments

@ted-xie
Copy link
Contributor

ted-xie commented Aug 3, 2023

See this BazelCI run for commit 088f922. @bazel_tools//tools/android:desugar_java8_legacy_libs is failing because it still references legacy desugarer flags, even after the default desugar tool in Bazel was switched to D8 in Bazel 6.0.0. This needs to be fixed in Bazel.
copybara-service bot pushed a commit that referenced this issue Aug 3, 2023
@ted-xie @copybara-github
Exclude //tools/android from BazelCI build temporarily
ad581ec 
See issue #122.

PiperOrigin-RevId: 553548670
Change-Id: I9af99c23cecea072f7bb5d402684e749f55952c9
copybara-service bot pushed a commit to google/desugar_jdk_libs that referenced this issue Sep 5, 2023
@ted-xie
Avoid pulling in @google_bazel_common
7f35770 
bazel_common pulls in a lot of extra libraries that this repository doesn't necessarily need. The main extra deps that desugar_jdk_libs needed were:

bazel-skylib
android_sdk_repository
jsr305 and AutoValue annotation processors
These could all be pulled piecemeal through WORKSPACE dependencies. This change makes integrating desugar_jdk_libs easier due to fewer external dependencies.

Related to bazelbuild/rules_android#122
Closes #10

PiperOrigin-RevId: 562874710
copybara-service bot pushed a commit to google/desugar_jdk_libs that referenced this issue Sep 5, 2023
@ted-xie
Copies jar from desugar_jdk_libs_jdk11 -> desugar_jdk_libs. This is i…
cfab9dc 
…ntended to help with legacy target path compatibility.

Related to bazelbuild/rules_android#122
Closes #9

PiperOrigin-RevId: 562874934
copybara-service bot pushed a commit to google/desugar_jdk_libs that referenced this issue Sep 6, 2023
@ted-xie
Fix genrule for android_jar for bazel builds
39c37bb 
Use the convenience alias in @bazel_tools
Related to bazelbuild/rules_android#122

PiperOrigin-RevId: 563179192
copybara-service bot pushed a commit to google/desugar_jdk_libs that referenced this issue Sep 6, 2023
@ted-xie
Make :desugar_jdk_libs public visibility
87ed6c8 
Otherwise the android_tools runtime dep build will fail.
Related to bazelbuild/rules_android#122

PiperOrigin-RevId: 563192467
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Sep 7, 2023
@ted-xie @copybara-github
Update desugar_jdk_libs version
8f8e956 
Related to bazelbuild/rules_android#122

PiperOrigin-RevId: 563498220
Change-Id: Iafdb2128235797a6260b9c0db40806f88bd63b30
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Sep 13, 2023
@ted-xie @copybara-github
Add codepaths for D8 core library desugaring
7c1b139 
Also deletes the classic core library desugarer.

bazelbuild/rules_android#122

PiperOrigin-RevId: 565104061
Change-Id: I8d78871a4b9e539388f4b328441e135c6365afc2
dx404 pushed a commit to google/desugar_jdk_libs that referenced this issue Sep 27, 2023
@ted-xie @dx404
Create workspace setup macros for desugar_jdk_libs
76ef014 
bazelbuild/rules_android#122

PiperOrigin-RevId: 567642987
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Oct 5, 2023
@ted-xie @copybara-github
Short-circuit bazel intrinsic Android library desugaring
85855fc 
This feature has never really worked, and there's no point to keeping the broken code around. We will fix forward in rules_android. We'll keep the desugar_java8_legacy_libs target for now to avoid breaking various things that may depend on it simply existing.

Related to bazelbuild/rules_android#122

PiperOrigin-RevId: 571135204
Change-Id: I8f191d5492ce8ee0c735e2a036f1d9013ac06914
copybara-service bot pushed a commit that referenced this issue Jan 18, 2024
@ted-xie @copybara-github
New utility to extract pgcfg flags from desugar_jdk_libs JSON config
68b9d5b 
Part of #122

PiperOrigin-RevId: 599570728
Change-Id: I8683c6841553dadf0747d9a721e377323b455d5c
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@ted-xie
Exclude //tools/android from BazelCI build temporarily
00937b1 
See issue bazelbuild#122.

PiperOrigin-RevId: 553548670
Change-Id: I9af99c23cecea072f7bb5d402684e749f55952c9
jylinv0 pushed a commit to jylinv0/rules_android that referenced this issue Jan 23, 2024
@ted-xie
New utility to extract pgcfg flags from desugar_jdk_libs JSON config
3168cc7 
Part of bazelbuild#122

PiperOrigin-RevId: 599570728
Change-Id: I8683c6841553dadf0747d9a721e377323b455d5c
copybara-service bot pushed a commit that referenced this issue Jan 24, 2024
@ted-xie @copybara-github
Fix flag extraction bug in extract_desugar_pgcfg_flags
15818b2 
Previous implementation would just blindly split the shrinker_config field as a string by spaces. This logic is incorrect. The right thing to do is to tell the program what format the data is coming in as (i.e. define the struct for the shrinker config flags), and unmarshall the JSON bytes with that in mind.

This CL also enhances the test for this tool to better reflect the actual intended logic.

Part of #122

PiperOrigin-RevId: 601239403
Change-Id: Id4d3e5b7daa92f3d07d588894234f7a2add41f1e
copybara-service bot pushed a commit that referenced this issue Feb 27, 2024
@ted-xie @copybara-github
Extract the desugar config json from maven for OSS rules_android
a542286 
Part of #122

PiperOrigin-RevId: 610829470
Change-Id: I3b565e9ca432a777237ad3af242f0e322f3b3fe7
ted-xie added a commit to ted-xie/rules_android that referenced this issue Mar 21, 2024
@ted-xie
Building java8_legacy_dex works
a524652 
Part of bazelbuild#122
This was referenced Mar 21, 2024
Closed
Closed
ted-xie added a commit to ted-xie/bazel that referenced this issue Mar 22, 2024
@ted-xie
Set public visibility for R8 desugar binary
3b676ed 
We are migrating Android functionality out of Bazel into rules_android.
Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the
R8 desugar binary. Going forward, we'll maintain the sh_binary directly
in rules_android, and therefore will require public visibility on
[...]/r8:desugar. Eventually the source code for the Bazel R8 desugar
wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this issue Mar 22, 2024
@ted-xie @copybara-github
Set public visibility for R8 desugar binary
32fd6e9 
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes #21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1
copybara-service bot pushed a commit that referenced this issue Mar 27, 2024
@ted-xie @copybara-github
Merge #221 by ted-xie: Building java8_legacy_dex works
62ef070 
Part of #122
Closes #221

COPYBARA_INTEGRATE_REVIEW=#221 from ted-xie:library_desugaring c410842
PiperOrigin-RevId: 619523388
Change-Id: Ifa3365e72886284df44ca6ceb53be113d4c97d1c
copybara-service bot pushed a commit that referenced this issue Apr 5, 2024
@ted-xie @copybara-github
Handle desugared_lib_config in src/tools/ak/dex
65eb82b 
Part of #122

PiperOrigin-RevId: 622183260
Change-Id: Iaa4ad14faa99acd0743a8e1d5387401a916c44b9
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Apr 29, 2024
@ted-xie @bazel-io
Set public visibility for R8 desugar binary
4a1b927 
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes bazelbuild#21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1
@bazel-io bazel-io mentioned this issue Apr 29, 2024
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Apr 29, 2024
@ted-xie @bazel-io
Set public visibility for R8 desugar binary
834b824 
We are migrating Android functionality out of Bazel into rules_android. Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the R8 desugar binary. Going forward, we'll maintain the sh_binary directly in rules_android, and therefore will require public visibility on [...]/r8:desugar. Eventually the source code for the Bazel R8 desugar wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes bazelbuild#21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1
@bazel-io bazel-io mentioned this issue Apr 29, 2024
Merged
github-merge-queue bot pushed a commit to bazelbuild/bazel that referenced this issue Apr 29, 2024
@bazel-io @ted-xie
[7.2.0] Set public visibility for R8 desugar binary (#22178)
1ab19fe 
We are migrating Android functionality out of Bazel into rules_android.
Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the
R8 desugar binary. Going forward, we'll maintain the sh_binary directly
in rules_android, and therefore will require public visibility on
[...]/r8:desugar. Eventually the source code for the Bazel R8 desugar
wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes #21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1

Commit
32fd6e9

Co-authored-by: Ted Xie <[email protected]>
Wyverald added a commit to bazelbuild/bazel that referenced this issue May 8, 2024
@bazel-io @ted-xie @Wyverald
[7.1.2] Set public visibility for R8 desugar binary (#22176)
a1dcae8 
We are migrating Android functionality out of Bazel into rules_android.
Currently rules_android depends on
@bazel_tools//tools/android:desugar_java8 for a sh_binary that calls the
R8 desugar binary. Going forward, we'll maintain the sh_binary directly
in rules_android, and therefore will require public visibility on
[...]/r8:desugar. Eventually the source code for the Bazel R8 desugar
wrapper will also move into rules_android.

Part of bazelbuild/rules_android#122.

Closes #21775.

PiperOrigin-RevId: 618272641
Change-Id: I09d9ca19b742049c2d29a75336d1b0680b0005b1

Commit
32fd6e9

Co-authored-by: Ted Xie <[email protected]>
Co-authored-by: Xùdōng Yáng <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 29, 2024
@ted-xie @copybara-github
Migrate library desugaring logic to rules_android
613b117 
Also contains various fixes for desugaring logic in OSS Android builds. NOTE: library desugaring doesn't work with persistent worker mode.

#122

PiperOrigin-RevId: 638095332
Change-Id: Idff5af5142e2debcf9b81b49f7e671020ad4d0ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ted-xie ted-xie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ted-xie