Skip to content

Commit

Permalink
do not iterate over deps
Browse files Browse the repository at this point in the history
Fixes break "type 'select' is not iterable"

PiperOrigin-RevId: 582319381
Change-Id: I7da9bf219426c1d28cfca036b039c6fb47e43b44
  • Loading branch information
A Googler authored and copybara-github committed Nov 14, 2023
1 parent b7870f6 commit 988adb4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions rules/android_application/android_application_rule.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -453,12 +453,12 @@ def android_application_macro(_android_binary, **attrs):
# In the future bundle_config will accept a build rule rather than a raw file.
bundle_config_file = bundle_config_file or bundle_config

deps = [d for d in attrs.pop("deps", [])]
deps = attrs.pop("deps", [])
for feature_module in feature_modules:
if not feature_module.startswith("//") or ":" not in feature_module:
_log.error("feature_modules expects fully qualified paths, i.e. //some/path:target")
module_targets = get_feature_module_paths(feature_module)
deps.append(str(module_targets.title_lib))
deps = deps + [str(module_targets.title_lib)]

_android_binary(
name = base_split_name,
Expand Down

0 comments on commit 988adb4

Please sign in to comment.