Split the Capabilities by endpoints #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ola-rozenfeld
requested review from
agoulti,
bergsieker,
buchgr and
ulfjack
as code owners
googlebot
added
the
cla: yes
buchgr
reviewed
May 9, 2019
| // GetCapabilities returns the server capabilities configuration of the | ||
| // remote endpoint. | ||
| // Only the capabilities of the services supported by the endpoint will | ||
| // be returned. For example: |
There was a problem hiding this comment.
Is 'For example' necessary here? Couldn't we simply specify an exhaustive list?
There was a problem hiding this comment.
Hmm, I guess this is already an exhaustive list :-)
buchgr
reviewed
May 9, 2019
|
Maybe I missed this in a separate discussion but is it the case that we cannot host the ActionCache separately from the CAS? |
|
Correct, these two are linked.
…On Thu, May 9, 2019 at 4:04 PM Ed Baunton ***@***.***> wrote:
Maybe I missed this in a separate discussion but is it the case that we
cannot host the ActionCache separately from the CAS?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGFAVOGKO4A4DROZRSXNVUTPUR7UZANCNFSM4HL4PXIA>
.
|
bergsieker
approved these changes
Jun 3, 2019
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 3, 2020
According to changes in bazelbuild/remote-apis#76 (and discussion in bazelbuild/remote-apis#61): > Each endpoint should implement the Capabilities service, and populate the fields relevant to the services available at that endpoint. Clients may choose to ignore irrelevant capabilities if the client does not plan to use a given service on the specified endpoint. This PR: 1. Refactor `RemoteModule` to use a `ChannelFactory` when creating channels so that tests can mock into channels connected to a fake server. 2. Add tests for verifying server capabilities. 3. Only check required capabilities for a given endpoint. - If `--remote_executor` and `--remote_cache point` to the same endpoint, we require that endpoint has both execution and cache capabilities. - If they point to different endpoints, we check the endpoint with execution or cache capabilities respectively. Fixes #11901. Closes #12008. PiperOrigin-RevId: 329875749
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61.
Will need to fix Bazel to match!