Replace VFS with a manifest file for copying aspects #7259
Merged
+178
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product: CLion
ujohnny
reviewed
Feb 3, 2025
Since vfs is not requires some hacks with to refresh files and might break in future it should be avoided. Further more, vfs is not available in some tests and this way logic for copying aspects can be reused.
ujohnny
approved these changes
Feb 4, 2025
github-actions
bot
removed
the
awaiting-review
LeFrosch
added a commit
to LeFrosch/intellij-bazel
that referenced
this pull request
Feb 11, 2025
Since vfs is not requires some hacks with to refresh files and might break in future it should be avoided. Further more, vfs is not available in some tests and this way logic for copying aspects can be reused. (cherry picked from commit 1f67a6f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since vfs is not requires some hacks with to refresh files and might
break in future it should be avoided. Further more, vfs is not available
in some tests and this way logic for copying aspects can be reused.