Remove --keep_going #669
Closed
Remove --keep_going #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until bazelbuild/bazel#7674 is resolved, it should not be used as a default flag in the CI.
|
Seems like the mentioned bug has been fixed by now, but we still might want this - if the build doesn't work, there's not much point to spend resources to run tests or continue building. |
philwo
force-pushed
the
master
branch
2 times, most recently
from
f67a23f to
16b4e3d
Compare
|
I just wanted to merge this, but the flag was already gone. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until bazelbuild/bazel#7674 is resolved, it should not be used as a default flag in the CI.