Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the functions docstring warning #543

Merged
merged 2 commits into from
Feb 12, 2019

Conversation

vladmos
Copy link
Member

@vladmos vladmos commented Feb 12, 2019

If a function is private or not long enough, don't force its docstring to have arguments or the return value documented.

However if at least some arguments are documented, check that all of them are.

Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vladmos vladmos merged commit fbccc74 into bazelbuild:master Feb 12, 2019
@vladmos vladmos deleted the small_functions_docstring branch February 12, 2019 18:28
cristiancreteanu pushed a commit to cristiancreteanu/buildtools that referenced this pull request Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants