Require proto rules to be loaded by buildifier #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the rules are moved into the repository the loads become mandatory with Bazel@HEAD. Add new warning for each rule and symbol that needs to be loaded. Buildifier doesn't handle well loading from different bzl files in a single warning. Enable all proto rules warning by default.
comius
requested review from
vladmos,
pmbethe09 and
larsrc-google
as code owners
vladmos
reviewed
Nov 28, 2024
vladmos
reviewed
Nov 28, 2024
|
Hey @meteorcloudy, any idea why build is failing on protobuf on this PR, but not on daily builds? |
meteorcloudy
requested changes
Nov 28, 2024
meteorcloudy
approved these changes
Nov 28, 2024
|
@vladmos Please take a final look to merge it |
vladmos
reviewed
Nov 28, 2024
vladmos
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the rules are moved into the repository the loads become mandatory with Bazel@HEAD.
Add new warning for each rule and symbol that needs to be loaded. Buildifier doesn't handle well loading from different bzl files in a single warning.
Enable all proto rules warning by default.