Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage deprecated io/iotil #1279

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

albertocavalcante
Copy link
Contributor

io/ioutil has been deprecated since Go 1.16.

This PR removes it in favor of equivalents in os and io packages.

@albertocavalcante
Copy link
Contributor Author

@vladmos can you please review whenever you get a chance? Thanks!

@albertocavalcante
Copy link
Contributor Author

There's an issue related to jq for macOS arm64, all other builds are passing. Added a comment regarding this on the tracking issue re: macos fleet migration bazelbuild/continuous-integration#1981 (comment)

Copy link
Member

@vladmos vladmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll fix the CI issue separately (not related to this PR) and merge it.

@vladmos vladmos merged commit 73857dd into bazelbuild:main Jul 30, 2024
2 checks passed
@albertocavalcante albertocavalcante deleted the remove-ioutil branch July 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants