Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bazel to 7.1.1 #564

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Mar 23, 2024

Switch to bzlmod exclusively (no WORKSPACE anymore).

Fix bzlmod integration with npm (originally added in #557 but didn't work at all). The 5.x series of rules_js is unmaintained and does not support bzlmod, and the 6.x series only has toolchains (with no packaging rules). Switch to aspect_rules_js which is currently the best source of npm packaging rules.


Obviously I haven't tried uploading the new npm package, but looking at the results in bazel-bin it seems to be comparable output to what currently happens on master.

Switch to bzlmod exclusively (no WORKSPACE anymore).

Fix bzlmod integration with npm. The 5.x series of rules_js is
unmaintained and does not support bzlmod, and the 6.x series only has
toolchains (with no packaging rules). Switch to aspect_rules_js which
is currently the best source of npm packaging rules.
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you very much!

@meteorcloudy meteorcloudy merged commit 24935f4 into bazelbuild:master Mar 25, 2024
2 checks passed
@jwnimmer-tri jwnimmer-tri deleted the use-bazel-7.1.1 branch March 25, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants