More exhaustive assertions for native rule tag propagation tests #25050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
hvadehra
added
team-Loading-API
coeuvre
approved these changes
Jan 29, 2025
coeuvre
added
awaiting-PR-merge
|
It seems like the test failure on macOS is legit. @Silic0nS0ldier, can you take a look? |
|
I've taken a look, this was caused by Easily fixed with a platform check which I'll have pushed up shortly. |
…ule-tag-propagation-assertions
github-actions
bot
removed
the
awaiting-PR-merge
coeuvre
pushed a commit
to bazelbuild/continuous-integration
that referenced
this pull request
Feb 4, 2025
Test failures can require information present in undeclared outputs to diagnose, which if not uploaded means needing to first reproduce the failure locally. e.g. https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/25623#0194aa2c-7bd9-466b-bd15-d7eec8ef58dc (failure in `test.log` references a file in `test.outputs`) from bazelbuild/bazel#25050 This PR adds uploading of `test.outputs/*` files for tests that fail/flake/timeout. It also; * Simplifies `local_exec_root.as_ref().map(|p| p.as_path()),` to `local_exec_root.as_deref(),` (clippy suggestion) * Lifts the upload decision (dubbed `include_output` in this PR) up a level so it can be used in the new code branch. I'm fairly `test.log` is a mandatory test output, so this change should not affect performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
src/test/shell/bazel/tags_propagation_native_test.shassert_contains_n "Command Line:" n output1ExecutionInfo: {is inappropriate asTemplateExpandalso have execution info.assert_contains_n "(local|no-cache|no-remote):" n output1Counting
nincreases confidence that all expected actions have the execution info they should have. e.g. tags propagated for tests, but not other actions when--incompatible_allow_tags_propagation=false--experimental_allow_tags_propagation->--incompatible_allow_tags_propagationAddresses warnings in test logs.
Changes in
src/test/shell/unittest.bashaddress a bug inassert_contains_nwhich on failure was using the wrong argument to refer to the input file. For consistency other places were also updated to use$fileinstead of the argument number.