Allow cc_binary with dynamic_deps to be extended
#24778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cc_binary` has an initializer that sets a private attribute, which is only permitted for built-in rules. The allowlist check always used the outermost rule class, thus failing if `cc_binary` is extended by a non-built-in rule. This is fixed by checking the rule class that actually declares the initializer.
fmeum
requested review from
katre and
comius
and removed request for
a team and
katre
github-actions
bot
added
team-Configurability
fmeum
changed the title
cc_binary to be extendedcc_binary with dynamic_deps to be extended
comius
approved these changes
Dec 20, 2024
comius
added
awaiting-PR-merge
|
@bazel-io fork 8.0.1 |
|
@bazel-io fork 7.5.0 |
This was referenced Dec 20, 2024
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 2, 2025
`cc_binary` has an initializer that may set a private attribute, which is only permitted for built-in rules. The allowlist check always used the outermost rule class, thus failing if `cc_binary` is extended by a non-built-in rule. This is fixed by checking the rule class that actually declares the initializer. Work towards bazelbuild#19507 (comment) Closes bazelbuild#24778. PiperOrigin-RevId: 711361632 Change-Id: I3c0b6e1e6c50fd1af9f1dc635052d0054114ee2d
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Jan 2, 2025
`cc_binary` has an initializer that may set a private attribute, which is only permitted for built-in rules. The allowlist check always used the outermost rule class, thus failing if `cc_binary` is extended by a non-built-in rule. This is fixed by checking the rule class that actually declares the initializer. Work towards bazelbuild#19507 (comment) Closes bazelbuild#24778. PiperOrigin-RevId: 711361632 Change-Id: I3c0b6e1e6c50fd1af9f1dc635052d0054114ee2d
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
`cc_binary` has an initializer that may set a private attribute, which is only permitted for built-in rules. The allowlist check always used the outermost rule class, thus failing if `cc_binary` is extended by a non-built-in rule. This is fixed by checking the rule class that actually declares the initializer. Work towards #19507 (comment) Closes #24778. PiperOrigin-RevId: 711361632 Change-Id: I3c0b6e1e6c50fd1af9f1dc635052d0054114ee2d Commit 7093088 Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc_binaryhas an initializer that may set a private attribute, which is only permitted for built-in rules. The allowlist check always used the outermost rule class, thus failing ifcc_binaryis extended by a non-built-in rule. This is fixed by checking the rule class that actually declares the initializer.Work towards #19507 (comment)