[8.0.1] Fix symlink planting for multiple aspects #24741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Skymeld is enabled, symlinks for external repositories are planted lazily in response to an event sent in `BuildDriverFunction`. For top-level aspects, this event needs to be sent individually for each aspect as the transitive packages required can differ per aspect. `BuildDriverFunction` deduplicated all events, including the one for symlink planting, by type, which resulted in missing symlinks for actions registered by the second (and later) aspects. Fixes bazelbuild#24619 Closes bazelbuild#24676. PiperOrigin-RevId: 707458188 Change-Id: I9fe523bc746d29e6c6ddb6367e08ce2c6c48c69b
bazel-io
added
team-Local-Exec
joeleba
approved these changes
Dec 19, 2024
Merged
via the queue into
bazelbuild:release-8.0.1
with commit Dec 19, 2024
9264ea1
46 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Skymeld is enabled, symlinks for external repositories are planted lazily in response to an event sent in
BuildDriverFunction. For top-level aspects, this event needs to be sent individually for each aspect as the transitive packages required can differ per aspect.BuildDriverFunctiondeduplicated all events, including the one for symlink planting, by type, which resulted in missing symlinks for actions registered by the second (and later) aspects.Fixes #24619
Closes #24676.
PiperOrigin-RevId: 707458188
Change-Id: I9fe523bc746d29e6c6ddb6367e08ce2c6c48c69b
Commit f4b071c