Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5.0] java_launcher: Fix non-portable ofstream usage #24725

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

bazel-io
Copy link
Member

wofstream cannot be constructed from wstring according to the standard https://en.cppreference.com/w/cpp/io/basic_ofstream/basic_ofstream.

Closes #24703.

PiperOrigin-RevId: 707172911
Change-Id: I973f9560c5b20748e4635cd757f53fff9c8ef0c5

Commit 5b35276

wofstream cannot be constructed from wstring according to the standard https://en.cppreference.com/w/cpp/io/basic_ofstream/basic_ofstream.

Closes bazelbuild#24703.

PiperOrigin-RevId: 707172911
Change-Id: I973f9560c5b20748e4635cd757f53fff9c8ef0c5
@bazel-io bazel-io added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Dec 17, 2024
@bazel-io bazel-io requested a review from a team as a code owner December 17, 2024 19:11
@iancha1992 iancha1992 removed the request for review from fmeum December 17, 2024 19:17
@iancha1992 iancha1992 enabled auto-merge (squash) December 17, 2024 19:17
@meteorcloudy meteorcloudy added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@meteorcloudy meteorcloudy added this pull request to the merge queue Dec 18, 2024
Merged via the queue into bazelbuild:release-7.5.0 with commit b81686d Dec 18, 2024
50 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants