Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing cpu.max file in cgroup v2 implementation #24714

Closed
wants to merge 2 commits into from
Closed

Fix parsing cpu.max file in cgroup v2 implementation #24714

wants to merge 2 commits into from

Conversation

AlessandroPatti
Copy link
Contributor

Fixes #24680

@github-actions github-actions bot added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Dec 16, 2024
@fmeum
Copy link
Collaborator

fmeum commented Dec 16, 2024

@bazel-io fork 8.0.1

@bazel-io bazel-io mentioned this pull request Dec 16, 2024
Closed
bigelephant29
bigelephant29 requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@bigelephant29 bigelephant29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I've left a few comments.

src/test/java/com/google/devtools/build/lib/sandbox/cgroups/CpuTest.java Show resolved Hide resolved
src/test/java/com/google/devtools/build/lib/sandbox/cgroups/CpuTest.java Show resolved Hide resolved
src/test/java/com/google/devtools/build/lib/sandbox/cgroups/CpuTest.java Outdated Show resolved Hide resolved
@bigelephant29 bigelephant29 added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 18, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 19, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 19, 2024
@AlessandroPatti @bazel-io
Fix parsing cpu.max file in cgroup v2 implementation
ba11b2a 
Fixes bazelbuild#24680

Closes bazelbuild#24714.

PiperOrigin-RevId: 707775390
Change-Id: I1a34c0917174aca3bbcfdec8668aef2d7e68ae6e
@bazel-io bazel-io mentioned this pull request Dec 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2024
@bazel-io @AlessandroPatti
[8.0.1] Fix parsing cpu.max file in cgroup v2 implementation (#24753)
d816b82 
Fixes #24680

Closes #24714.

PiperOrigin-RevId: 707775390
Change-Id: I1a34c0917174aca3bbcfdec8668aef2d7e68ae6e

Commit
1c6aa50

Co-authored-by: Alessandro Patti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigelephant29 bigelephant29 bigelephant29 approved these changes

Assignees
No one assigned
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting --experimental_sandbox_limits=cpu=N fails with NoSuchElementException
3 participants
@AlessandroPatti @fmeum @bigelephant29