Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking objc binaries in the root package #24698

Closed
wants to merge 1 commit into from
Closed

Fix linking objc binaries in the root package #24698

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Dec 14, 2024

Fixes #24625

@keith keith requested a review from pzembrod December 14, 2024 01:00
@keith
Copy link
Member Author

keith commented Dec 14, 2024

@bazel-io flag

@keith keith mentioned this pull request Dec 14, 2024
Closed
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 14, 2024
@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 14, 2024
@keith keith force-pushed the ks/fix-linking-objc-binaries-in-the-root-package branch from d58ca2d to 83133f8 Compare December 14, 2024 19:03
@fmeum
Copy link
Collaborator

fmeum commented Dec 16, 2024

@bazel-io fork 8.0.1

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 16, 2024
@bazel-io bazel-io mentioned this pull request Dec 16, 2024
Closed
pzembrod
pzembrod approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@pzembrod pzembrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @keith, for chasing this one down!

@pzembrod pzembrod added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 16, 2024
@sgowroji sgowroji added the team-Rules-ObjC Issues for Objective-C maintainers label Dec 17, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 17, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 17, 2024
@keith @bazel-io
Fix linking objc binaries in the root package
f0d4fc9 
Fixes bazelbuild#24625

Closes bazelbuild#24698.

PiperOrigin-RevId: 707183228
Change-Id: I369a37e8e652545274ec4949b1c3ac1d2fab38cb
@bazel-io bazel-io mentioned this pull request Dec 17, 2024
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 17, 2024
@keith @bazel-io
Fix linking objc binaries in the root package
919e820 
Fixes bazelbuild#24625

Closes bazelbuild#24698.

PiperOrigin-RevId: 707183228
Change-Id: I369a37e8e652545274ec4949b1c3ac1d2fab38cb
@bazel-io bazel-io mentioned this pull request Dec 17, 2024
Merged
@keith keith deleted the ks/fix-linking-objc-binaries-in-the-root-package branch December 17, 2024 19:37
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
@bazel-io @keith
[8.0.1] Fix linking objc binaries in the root package (#24726)
1861026 
Fixes #24625

Closes #24698.

PiperOrigin-RevId: 707183228
Change-Id: I369a37e8e652545274ec4949b1c3ac1d2fab38cb

Commit
2864f2a

Co-authored-by: Keith Smiley <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
@bazel-io @keith
[8.0.1] Fix linking objc binaries in the root package (#24727)
e12aebc 
Fixes #24625

Closes #24698.

PiperOrigin-RevId: 707183228
Change-Id: I369a37e8e652545274ec4949b1c3ac1d2fab38cb

Commit
2864f2a

Co-authored-by: Keith Smiley <[email protected]>
iancha1992 pushed a commit that referenced this pull request Dec 19, 2024
@keith @iancha1992
Fix linking objc binaries in the root package
03c9ce6 
Fixes #24625

Closes #24698.

PiperOrigin-RevId: 707183228
Change-Id: I369a37e8e652545274ec4949b1c3ac1d2fab38cb
@fmeum fmeum mentioned this pull request Jan 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzembrod pzembrod pzembrod approved these changes

@fmeum fmeum fmeum approved these changes

Assignees
No one assigned
Labels
team-Rules-ObjC Issues for Objective-C maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel 8 crash when building ios_application at the root
5 participants
@keith @fmeum @pzembrod @bazel-io @sgowroji