Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also apply --experimental_repository_downloader_retries to a SocketException #24608

Closed
wants to merge 1 commit into from

Conversation

PareeshMadan
Copy link
Contributor

Fix for #24530

--experimental_repository_downloader_retries will now retry on SocketException in addition to ContentLengthMismatchException

Copy link

google-cla bot commented Dec 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels Dec 7, 2024
@PareeshMadan PareeshMadan force-pushed the fix-24530 branch 3 times, most recently from abbcc9b to c2f85a2 Compare December 7, 2024 23:00
@tjgq tjgq changed the title --experimental_repository_downloader_retries retries on SocketException Also apply --experimental_repository_downloader_retries to a SocketException Dec 9, 2024
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Dec 9, 2024
@fmeum
Copy link
Collaborator

fmeum commented Dec 9, 2024

@bazel-io flag

@fmeum
Copy link
Collaborator

fmeum commented Dec 9, 2024

(for 8.1.0)

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Dec 10, 2024
@iancha1992
Copy link
Member

@bazel-io fork 8.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Dec 10, 2024
@lpingas
Copy link

lpingas commented Dec 17, 2024

Hi, could we get this into 7.5 as well?

@fmeum
Copy link
Collaborator

fmeum commented Dec 17, 2024

@bazel-io fork 7.5.0

bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Dec 17, 2024
…ception

Fix for bazelbuild#24530

--experimental_repository_downloader_retries will now retry on `SocketException` in addition to `ContentLengthMismatchException`

Closes bazelbuild#24608.

PiperOrigin-RevId: 704633572
Change-Id: Idd1fcbb768c9dabed596fe15d8ae9260ef3e895d
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
…SocketException (#24722)

Fix for #24530

--experimental_repository_downloader_retries will now retry on
`SocketException` in addition to `ContentLengthMismatchException`

Closes #24608.

PiperOrigin-RevId: 704633572
Change-Id: Idd1fcbb768c9dabed596fe15d8ae9260ef3e895d

Commit
459bb57

Co-authored-by: Pareesh Madan <[email protected]>
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 18, 2025
…ception

Fix for bazelbuild#24530

--experimental_repository_downloader_retries will now retry on `SocketException` in addition to `ContentLengthMismatchException`

Closes bazelbuild#24608.

PiperOrigin-RevId: 704633572
Change-Id: Idd1fcbb768c9dabed596fe15d8ae9260ef3e895d
github-merge-queue bot pushed a commit that referenced this pull request Jan 20, 2025
…SocketException (#24969)

Fix for #24530

--experimental_repository_downloader_retries will now retry on
`SocketException` in addition to `ContentLengthMismatchException`

Closes #24608.

PiperOrigin-RevId: 704633572
Change-Id: Idd1fcbb768c9dabed596fe15d8ae9260ef3e895d

Commit
459bb57

Co-authored-by: Pareesh Madan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants