Only process executable path for path mapping #24576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few issues introduced in 282ac62: * Only the executable path in the first argument of a `CommandLines` instance should be subject to path mapping. * String arguments that are not normalized as path strings and thus can't possibly be the optimized memory representation used for the executable arg by `StarlarkAction` should not be modified. Also removes an class that became unused in that commit.
|
@bazel-io flag |
|
(for 8.0.1 or 8.1.0) |
github-actions
bot
added
team-Performance
bazel-io
added
the
potential release blocker
justinhorvitz
approved these changes
Dec 6, 2024
src/test/java/com/google/devtools/build/lib/actions/CommandLinesTest.java
Outdated
Show resolved
Hide resolved
|
@meteorcloudy If this makes it in time for the next 8.0.0 RC, it would be safer to include it. |
github-actions
bot
removed
the
awaiting-review
|
@bazel-io fork 8.0.0 |
bazel-io
removed
the
potential release blocker
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Dec 6, 2024
This fixes a few issues introduced in 282ac62: * Only the executable path in the first argument of a `CommandLines` instance should be subject to path mapping. * String arguments that are not normalized as path strings and thus can't possibly be the optimized memory representation used for the executable arg by `StarlarkAction` should not be modified. Also removes an class that became unused in that commit. Closes bazelbuild#24576. PiperOrigin-RevId: 703536848 Change-Id: I358696bc268ab1f400798ef55ea4db8d556f07dd
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
This fixes a few issues introduced in 282ac62: * Only the executable path in the first argument of a `CommandLines` instance should be subject to path mapping. * String arguments that are not normalized as path strings and thus can't possibly be the optimized memory representation used for the executable arg by `StarlarkAction` should not be modified. Also removes an class that became unused in that commit. Closes #24576. PiperOrigin-RevId: 703536848 Change-Id: I358696bc268ab1f400798ef55ea4db8d556f07dd Commit b00576d Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues introduced in 282ac62:
CommandLinesinstance should be subject to path mapping.StarlarkActionshould not be modified.Also removes an class that became unused in that commit.