[8.0.0-pre.20240805.3] Be resilient to outdated exec paths in action cache entries #23269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60924fd changed the canonical repo name separator from `~` to `+`. Older repo names containing `~` now trigger a syntax error. If an action cache entry refers to an exec path from a previous version of Bazel that used `~`, we need to be resilient and treat the cache entry as corrupted, rather than just crash. Fixes #23180. Closes #23227. PiperOrigin-RevId: 660105601 Change-Id: Iea5d86c635056d12ba20598383da463bdde03ab0
keertk
requested review from
meteorcloudy and
fweikert
and removed request for
lberki
github-actions
bot
added
team-Rules-CPP
meteorcloudy
approved these changes
Aug 12, 2024
meteorcloudy
changed the title
meteorcloudy
changed the title
keertk
merged commit 26cf11e
into
bazelbuild:release-8.0.0-pre.20240805.3rc1
52 checks passed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
60924fd changed the canonical repo name separator from
~to+. Older repo names containing~now trigger a syntax error. If an action cache entry refers to an exec path from a previous version of Bazel that used~, we need to be resilient and treat the cache entry as corrupted, rather than just crash.Fixes #23180.
Closes #23227.
PiperOrigin-RevId: 660105601
Change-Id: Iea5d86c635056d12ba20598383da463bdde03ab0