Only check for shard status file if a test passed #22098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file. Speculatively fixes bazelbuild#22028
github-actions
bot
added
the
awaiting-review
|
@bazel-io fork 7.2.0 |
bazel-io
added
the
potential release blocker
iancha1992
added
team-OSS
tjgq
approved these changes
Apr 25, 2024
tjgq
added
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Apr 26, 2024
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file. Speculatively fixes bazelbuild#22028 Closes bazelbuild#22098. PiperOrigin-RevId: 628355694 Change-Id: I370c7aba331f2a7a89cb9a9ff99d32b1694fd03a
sgowroji
removed
the
awaiting-PR-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2024
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file. Speculatively fixes #22028 Closes #22098. PiperOrigin-RevId: 628355694 Change-Id: I370c7aba331f2a7a89cb9a9ff99d32b1694fd03a Commit 874a050 Co-authored-by: Fabian Meumertzheim <[email protected]>
Kila2
pushed a commit
to Kila2/bazel
that referenced
this pull request
May 13, 2024
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file. Speculatively fixes bazelbuild#22028 Closes bazelbuild#22098. PiperOrigin-RevId: 628355694 Change-Id: I370c7aba331f2a7a89cb9a9ff99d32b1694fd03a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test fails, the failure is going to be informative than a generic exec error and the failure may have interrupted or prevented the test runner from touching the status file.
Speculatively fixes #22028