Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -fatal_warnings on macOS #20924

Closed

Conversation

keith
Copy link
Member

@keith keith commented Jan 17, 2024

Fixes #20919

@github-actions github-actions bot added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 17, 2024
@keith
Copy link
Member Author

keith commented Jan 22, 2024

@comius can you review?

@comius comius added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 23, 2024
@comius
Copy link
Contributor

comius commented Jan 23, 2024

Thanks @keith!

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 24, 2024
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 24, 2024
@iancha1992
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jan 24, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Jan 24, 2024
Fixes bazelbuild#20919

Closes bazelbuild#20924.

PiperOrigin-RevId: 601022242
Change-Id: I257023dcf9983cb2b3ce16079675f6b5f9409b86
github-merge-queue bot pushed a commit that referenced this pull request Jan 25, 2024
Fixes #20919

Closes #20924.

Commit
3d7c5ae

PiperOrigin-RevId: 601022242
Change-Id: I257023dcf9983cb2b3ce16079675f6b5f9409b86

Co-authored-by: Keith Smiley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treat_warnings_as_errors feature doesn't work on macOS
5 participants