[Duplicate] Allow repo rules to download multiple things in parallel. #20857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is accomplished by adding a "block" argument to the "download" call. If set, the call returns a "pending download" object with one single method that waits for the download to finish. Appropriate care is taken that downloads don't hang around after the repository function finishes running. Fixes bazelbuild#19674 . RELNOTES: None. PiperOrigin-RevId: 588320352 Change-Id: Ib0f48b6c7c2a07e93a4af602b0045120bd418829
bazel-io
added
team-ExternalDeps
bazel-io
added
the
awaiting-review
iancha1992
requested review from
lberki
and removed request for
a team and
lberki
|
Duplicate of #20856 |
iancha1992
changed the title
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by adding a "block" argument to the "download" call. If set,
the call returns a "pending download" object with one single method that waits for the download to finish.
Appropriate care is taken that downloads don't hang around after the repository function finishes running.
Fixes #19674 .
RELNOTES: None.
Commit 73c1a1e
PiperOrigin-RevId: 588320352
Change-Id: Ib0f48b6c7c2a07e93a4af602b0045120bd418829