Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid emitting canonical labels into generated repos #20810

Closed
wants to merge 1 commit into from
Closed

Avoid emitting canonical labels into generated repos #20810

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jan 9, 2024 •
edited
Loading

As long as #20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.

@fmeum fmeum requested a review from Wyverald January 9, 2024 16:57
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jan 9, 2024
@fmeum fmeum mentioned this pull request Jan 9, 2024
Closed
@fmeum fmeum force-pushed the 20722-remove-labels branch from fb8f3ca to 0ebc477 Compare January 9, 2024 17:00
@fmeum
Avoid emitting canonical labels into repo rules
1bbb52e 
As long as bazelbuild#20722 isn't resolved, the canonical name for the given
apparent name can change without the repo rule being refetched.
@fmeum fmeum force-pushed the 20722-remove-labels branch from 0ebc477 to 1bbb52e Compare January 9, 2024 17:19
@fmeum fmeum changed the title Avoid emitting canonical labels into repo rules Avoid emitting canonical labels into generated repos Jan 9, 2024
@Wyverald
Copy link
Member

Wyverald commented Jan 9, 2024

Just so I understand, this won't break any users, right? We did this originally to anticipate for the move of java_import into rules_java, so before that happens, it doesn't matter whether we use the native java_import or the rules_java one?

Side note: I think we need to eventually deprecate http_jar and move it into rules_java anyway. Weird that jars get special treatment.

@fmeum
Copy link
Collaborator Author

fmeum commented Jan 9, 2024

I think that this is safe, these are pure forwarders except for a tag. With the caveat that someone out there may be patching rules_java with custom rule logic, but I don't think that's a supported use case.

@Wyverald
Copy link
Member

Wyverald commented Jan 9, 2024

OK. I think I'm more comfortable with cherry-picking this one for 7.0.1 (instead of waiting on a fix for #20722). WDYT?

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jan 9, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Jan 9, 2024

OK. I think I'm more comfortable with cherry-picking this one for 7.0.1 (instead of waiting on a fix for #20722). WDYT?

I agree, 7.0.1 is probably already the largest point release ever.

@Wyverald
Copy link
Member

Wyverald commented Jan 9, 2024

@bazel-io fork 7.0.1

@bazel-io bazel-io mentioned this pull request Jan 9, 2024
Closed
@Wyverald Wyverald mentioned this pull request Jan 9, 2024
Closed
@iancha1992
Copy link
Member

@bazel-io fork 7.1.0

@bazel-io bazel-io mentioned this pull request Jan 9, 2024
Closed
@copybara-service copybara-service bot closed this in 1c45bc5 Jan 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jan 9, 2024
@fmeum fmeum deleted the 20722-remove-labels branch January 10, 2024 08:00
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 10, 2024
@fmeum
[7.0.1] Avoid emitting canonical labels into generated repos
7a7acb8 
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.

Closes bazelbuild#20810.

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

Closes bazelbuild#20825
@fmeum fmeum mentioned this pull request Jan 10, 2024
Merged
fmeum added a commit to fmeum/bazel that referenced this pull request Jan 10, 2024
@fmeum
[7.0.1] Avoid emitting canonical labels into generated repos
950d310 
As long as bazelbuild#20722 isn't resolved, the canonical name for the given apparent name can change without the repo rule being refetched.

Closes bazelbuild#20810.

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

Closes bazelbuild#20825
iancha1992 pushed a commit that referenced this pull request Jan 10, 2024
@fmeum
[7.0.1] Avoid emitting canonical labels into generated repos (#20840)
ce993c4 
As long as #20722 isn't resolved, the canonical name for the given
apparent name can change without the repo rule being refetched.

Closes #20810.

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

Closes #20825
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.0.1 RC2. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

@keertk keertk mentioned this pull request Jan 17, 2024
Merged
@keertk keertk added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Jan 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2024
@keertk @fmeum
[7.1.0] Avoid emitting canonical labels into generated repos (#20917)
572f5ea 
As long as #20722 isn't resolved, the canonical name for the given
apparent name can change without the repo rule being refetched.

Closes #20810.
Commit
1c45bc5

PiperOrigin-RevId: 597048244
Change-Id: I225424cc32e572b26c6d6e76e2c09c4d2e6a4ba6

---------

Co-authored-by: Fabian Meumertzheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @Wyverald @iancha1992 @keertk