Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra resources #17229

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Extra resources #17229

merged 4 commits into from
Jan 19, 2023

Conversation

drewmacrae
Copy link
Contributor

This recreates a closed PR to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:#16817

Closes #16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68

Extra resources
af59cd0 
This recreates a [closed PR](bazelbuild#13996) to implement extra resources which we're hoping to use in lowRISC/opentitan#16436

Fixes:bazelbuild#16817

Closes bazelbuild#16785.

PiperOrigin-RevId: 498557024
Change-Id: I60d8f8f4a4a02748147cabb4cd60a2a9b95a2c68
@drewmacrae drewmacrae requested a review from ShreeM01 as a code owner January 17, 2023 15:48
@ShreeM01 ShreeM01 added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-user-response Awaiting a response from the author labels Jan 17, 2023
@drewmacrae
Copy link
Contributor Author

@kshyanashree I think I'm the user that the label indicates should respond, but I'm not sure how to respond. I can reproduce the first of these failures locally for this commit and it's parent.

//src/test/shell/bazel:git_repository_test fails on my workstation for both the cherry-pick and for the release commit that is its parent. Could you advise how to proceed?

@ShreeM01
Copy link
Contributor

@kshyanashree I think I'm the user that the label indicates should respond, but I'm not sure how to respond. I can reproduce the first of these failures locally for this commit and it's parent.

//src/test/shell/bazel:git_repository_test fails on my workstation for both the cherry-pick and for the release commit that is its parent. Could you advise how to proceed?

It is done. Thank you!

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Jan 19, 2023
@ShreeM01 ShreeM01 merged commit bcfc7f7 into bazelbuild:release-6.1.0 Jan 19, 2023
@eric-skydio eric-skydio mentioned this pull request Apr 28, 2023
Closed
This was referenced May 30, 2023
Merged
Merged
@dmcardle dmcardle mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShreeM01 ShreeM01 ShreeM01 approved these changes

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewmacrae @ShreeM01 @sgowroji