Fix repo_env crash with empty value #15540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-ExternalDeps
SalmaSamy
approved these changes
May 24, 2022
|
Hi there, friendly ping @meteorcloudy :) |
|
This is already fixed in ed886ee |
ShreeM01
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As reported by #15430, --repo_env option is now unable to read from environment variables.
This problem used to be fixed in #12886, but seems to be introduced again in commit c2bdd034014f66ce14529cc353cda18a32320f6c, line 256 and 257 link here where the value put into
repoEnvis still the original one that might benull. This commit would revert those changes and put the modified value intorepoEnv.