Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade com.google.thirdparty in JacocoCoverage.jarjar #15125

Closed
wants to merge 1 commit into from
Closed

Shade com.google.thirdparty in JacocoCoverage.jarjar #15125

wants to merge 1 commit into from

Conversation

thirtyseven
Copy link
Contributor

Fixes #15124

@google-cla
Copy link

google-cla bot commented Mar 25, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@thirtyseven
Copy link
Contributor Author

I have a failing test case for this too that I haven't pushed yet, but I realize there will have to be a new release of java_tools before it can pass. LMK if I should include it in this PR.

@ckolli5 ckolli5 added the team-Rules-Java Issues for Java rules label Mar 28, 2022
@ckolli5 ckolli5 requested a review from comius March 28, 2022 22:06
@comius
Copy link
Contributor

comius commented Mar 29, 2022

cc @c-mita, @cushon

@comius comius self-assigned this Mar 29, 2022
@bazel-io bazel-io closed this in 5b95286 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comius comius comius approved these changes

Assignees

@comius comius

Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
3 participants
@thirtyseven @comius @ckolli5