Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SettableFutures in remote module are all set. #12426

Closed
wants to merge 1 commit into from

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Nov 6, 2020

Failed doing so, will cause Bazel hanging forever. This could be one of causes for #11782.

Failed doing so, will cause Bazel hanging forever. This could be one of causes for bazelbuild#11782.
@coeuvre coeuvre requested a review from lberki November 6, 2020 08:53
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
@lberki lberki requested review from philwo and removed request for philwo November 9, 2020 08:07
@lberki
Copy link
Contributor

lberki commented Nov 9, 2020

Reassigning to @philwo since he should be back this week

Copy link
Member

@philwo philwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in c7c7f5f Nov 10, 2020
coeuvre added a commit to coeuvre/bazel that referenced this pull request Jan 28, 2021
Failed doing so, will cause Bazel hanging forever. This could be one of causes for bazelbuild#11782.

Closes bazelbuild#12426.

PiperOrigin-RevId: 341554621

# Conflicts:
#	src/main/java/com/google/devtools/build/lib/remote/GrpcCacheClient.java
#	src/main/java/com/google/devtools/build/lib/remote/http/HttpCacheClient.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants