Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set --remote_cache to --remote_executor if it is empty. #11998

Closed
wants to merge 1 commit into from

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Aug 24, 2020

Fixes #11913

@coeuvre coeuvre requested a review from philwo August 24, 2020 03:10
@ulfjack
Copy link
Contributor

ulfjack commented Aug 24, 2020

I'm not sure that this is the right fix. Conceptually, combining --remote_cache and --remote_executor would seem to imply that you're using different cache and executor, which is generally probably not what users want. I think it would make more sense to me to disallow having both set at the same time rather than doing this. (Now, that doesn't answer the question of how to fix the linked issue.)

@coeuvre
Copy link
Member Author

coeuvre commented Aug 25, 2020

Pointing --remote_cache and --remote_executor to different endpoints is allowed currently and I'm not sure whether users are using this feature or not. This PR tries to fix the linked issue without breaking current behavior. How about create another issue describing the problem you mentioned?

@coeuvre
Copy link
Member Author

coeuvre commented Aug 25, 2020

It seems that users are depended on combining --remote_cache and --remote_executor in some cases. See #11901 and some discussion in bazelbuild/remote-apis#61.

@bazel-io bazel-io closed this in 25e58ff Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote downloader cannot be used with --remote-executor
4 participants