Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel CI: rules_foreign_cc is broken on Windows #7195

Closed
meteorcloudy opened this issue Jan 21, 2019 · 1 comment
Closed

Bazel CI: rules_foreign_cc is broken on Windows #7195

meteorcloudy opened this issue Jan 21, 2019 · 1 comment
Assignees
Labels
breakage P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules

Comments

@meteorcloudy
Copy link
Member

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/765#50422cac-b7e0-4d1c-a518-102b74f18738


ERROR: D:/b/rs3544hw/external/rules_foreign_cc_tests/cmake_hello_world_lib/static/BUILD:19:1: in cmake_external rule @rules_foreign_cc_tests//cmake_hello_world_lib/static:libhello_win:
--
  | Traceback (most recent call last):
  | File "D:/b/rs3544hw/external/rules_foreign_cc_tests/cmake_hello_world_lib/static/BUILD", line 19
  | cmake_external(name = 'libhello_win')
  | File "D:/b/rs3544hw/external/rules_foreign_cc/tools/build_defs/cmake.bzl", line 47, in _cmake_external
  | cc_external_rule_impl(ctx, attrs)
  | File "D:/b/rs3544hw/external/foreign_cc_impl/framework.bzl", line 200, in cc_external_rule_impl
  | _define_out_cc_info(ctx, attrs, inputs, outputs)
  | File "D:/b/rs3544hw/external/foreign_cc_impl/framework.bzl", line 549, in _define_out_cc_info
  | create_linking_info(ctx, attrs.linkopts, outputs.librari...)
  | File "D:/b/rs3544hw/external/foreign_cc_impl/cc_toolchain_util.bzl", line 200, in create_linking_info
  | cc_common.create_linking_context(user_link_flags = user_link_flag..., ...))
  | File "D:/b/rs3544hw/external/foreign_cc_impl/cc_toolchain_util.bzl", line 202, in cc_common.create_linking_context
  | _create_libraries_to_link(ctx, files)
  | File "D:/b/rs3544hw/external/foreign_cc_impl/cc_toolchain_util.bzl", line 77, in _create_libraries_to_link
  | cc_common.create_library_to_link(actions = ctx.actions, feature_con..., <6 more arguments>)
  | Must pass parameters: static_library, pic_static_library, dynamic_library, interface_library and alwayslink.


/cc @oquenchil @irengrig

@meteorcloudy meteorcloudy added P1 I'll work on this now. (Assignee required) breakage team-Rules-CPP Issues for C++ rules labels Jan 21, 2019
@irengrig
Copy link
Contributor

Resolved by a fix of C++ team. Closing.
//ccc @hlopko

bazel-io pushed a commit that referenced this issue Jan 23, 2019
Fixes #7195

RELNOTES:none
PiperOrigin-RevId: 230523819
weixiao-huang pushed a commit to weixiao-huang/bazel that referenced this issue Jan 31, 2019
Fixes bazelbuild#7195

RELNOTES:none
PiperOrigin-RevId: 230523819
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
    Fixes bazelbuild/bazel#7195

    RELNOTES:none
    PiperOrigin-RevId: 230523819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage P1 I'll work on this now. (Assignee required) team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

No branches or pull requests

3 participants