Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel_dep allows missing version with poor error #17126

Closed
keith opened this issue Jan 3, 2023 · 5 comments
Closed

bazel_dep allows missing version with poor error #17126

keith opened this issue Jan 3, 2023 · 5 comments
Assignees
@Wyverald
Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests not stale Issues or PRs that are inactive but not considered stale P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@keith
Copy link
Member

keith commented Jan 3, 2023 •
edited
Loading

Description of the bug:

If you specify this in your MODULE.bazel:

bazel_dep(
    name = "apple_support",
)

bazel errors with:

ERROR: Error computing the main repository mapping: module not found in registries: apple_support@_

I imagine omitting a version is supported for overrides(?), but i think ideally the error would hint to the user that they are missing the version.

What is the output of bazel info release?

release 6.0.0rc4
@sgowroji sgowroji added type: bug team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged area-Bzlmod Bzlmod-specific PRs, issues, and feature requests labels Jan 4, 2023
@Wyverald Wyverald added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 30 days. It will be closed in the next 7 days unless any other activity occurs or the "not stale" label is added.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 9, 2023
@brentleyjones
Copy link
Contributor

@keertk not stale, triaged and not waiting for input

@sgowroji sgowroji removed the stale Issues or PRs that are stale (no activity for 30 days) label Feb 9, 2023
@keertk keertk added the not stale Issues or PRs that are inactive but not considered stale label Feb 9, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 7, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 7, 2023
This was referenced Aug 7, 2023
Closed
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Aug 7, 2023
@Wyverald @bazel-io
Friendlier error message for bazel_deps without version
b8a5704 
Ideally we would also include the location of the offending bazel_dep, but that requires a (slightly?) bigger change to record the locations of all bazel_deps.

Fixes bazelbuild#17126

PiperOrigin-RevId: 554406088
Change-Id: I46865c31dc983de18ac64a37e8ee15ebec624937
Wyverald added a commit that referenced this issue Aug 7, 2023
@bazel-io @Wyverald
Friendlier error message for bazel_deps without version (#19196)
f6a30b4 
Ideally we would also include the location of the offending bazel_dep, but that requires a (slightly?) bigger change to record the locations of all bazel_deps.

Fixes #17126

PiperOrigin-RevId: 554406088
Change-Id: I46865c31dc983de18ac64a37e8ee15ebec624937

Co-authored-by: Googler <[email protected]>
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wyverald Wyverald

Labels
area-Bzlmod Bzlmod-specific PRs, issues, and feature requests not stale Issues or PRs that are inactive but not considered stale P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@brentleyjones @keith @Wyverald @bazel-io @sgowroji @keertk @iancha1992