Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--modify_execution_info should be additive #13342

Closed
brentleyjones opened this issue Apr 13, 2021 · 5 comments
Closed

--modify_execution_info should be additive #13342

brentleyjones opened this issue Apr 13, 2021 · 5 comments
Labels
not stale Issues or PRs that are inactive but not considered stale P2 We'll consider working on this in future. (Assignee optional) team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request

Comments

@brentleyjones
Copy link
Contributor

Description of the problem / feature request:

Calling --modify_execution_info multiple times results in the last version being used, instead of allowing the addition/removal of current execution info. It should be additive, or a new flag should exist that allows it to be called multiple times.

Feature requests: what underlying problem are you trying to solve with this feature?

In different --config we want to set different execution info. In particular, when conditionally using remote execution, and conditionally running on CI, we want to set different execution info.

What operating system are you running Bazel on?

macOS

What's the output of bazel info release?

release 4.0.0
@jin jin added team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request untriaged labels Apr 14, 2021
@meisterT meisterT added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Jun 17, 2021
@brentleyjones
Copy link
Contributor Author

This is still pretty annoying for us. We've had to switch in conditionally importing different .bazelrc based on if we are using remote exec or not.

sitaktif added a commit to sitaktif/bazel that referenced this issue Sep 13, 2022
@sitaktif
Make --modify_execution_info additive
7ef66ea 
Calling --modify_execution_info multiple times used to result in the
last version being used. With this change, options are amended
additively.

Fixes bazelbuild#13342
@sitaktif sitaktif mentioned this issue Sep 13, 2022
Closed
sitaktif added a commit to sitaktif/bazel that referenced this issue Dec 16, 2022
@sitaktif
Make --modify_execution_info additive
27395e2 
Calling --modify_execution_info multiple times used to result in the
last version being used. With this change, options are amended
additively.

Fixes bazelbuild#13342
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 25, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@brentleyjones
Copy link
Contributor Author

Hmm, not stale.

@brentleyjones brentleyjones reopened this Jun 8, 2023
@brentleyjones brentleyjones added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels Jun 8, 2023
sitaktif added a commit to sitaktif/bazel that referenced this issue May 7, 2024
@sitaktif
Make --modify_execution_info additive
185c4aa 
Calling --modify_execution_info multiple times used to result in the
last version being used. With this change, options are amended
additively.

Fixes bazelbuild#13342
coeuvre pushed a commit to coeuvre/bazel that referenced this issue May 10, 2024
@sitaktif @coeuvre
Make --modify_execution_info additive
a595eec 
Calling --modify_execution_info multiple times used to result in the last version being used. With this change, options are amended additively if --incompatible_modify_execution_info_additive is set.

Fixes bazelbuild#13342

Closes bazelbuild#16262.

PiperOrigin-RevId: 631803759
Change-Id: I5386cbb0d02ef19a6b2ddf2f818cbab660b17c31
@coeuvre coeuvre mentioned this issue May 10, 2024
Merged
coeuvre pushed a commit to coeuvre/bazel that referenced this issue May 10, 2024
@sitaktif @coeuvre
Make --modify_execution_info additive
352fb05 
Calling --modify_execution_info multiple times used to result in the last version being used. With this change, options are amended additively if --incompatible_modify_execution_info_additive is set.

Fixes bazelbuild#13342

Closes bazelbuild#16262.

PiperOrigin-RevId: 631803759
Change-Id: I5386cbb0d02ef19a6b2ddf2f818cbab660b17c31
github-merge-queue bot pushed a commit that referenced this issue May 10, 2024
@coeuvre @sitaktif
[7.2.0] Make --modify_execution_info additive (#22316)
e0fdd60 
Calling --modify_execution_info multiple times used to result in the
last version being used. With this change, options are amended
additively if --incompatible_modify_execution_info_additive is set.

Fixes #13342

Closes #16262.

PiperOrigin-RevId: 631803759
Change-Id: I5386cbb0d02ef19a6b2ddf2f818cbab660b17c31

Closes #22288.

Co-authored-by: Romain Chossart <[email protected]>
Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
@sitaktif @Kila2
Make --modify_execution_info additive
4004ed9 
Calling --modify_execution_info multiple times used to result in the last version being used. With this change, options are amended additively if --incompatible_modify_execution_info_additive is set.

Fixes bazelbuild#13342

Closes bazelbuild#16262.

PiperOrigin-RevId: 631803759
Change-Id: I5386cbb0d02ef19a6b2ddf2f818cbab660b17c31
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 7.2.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.2.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
not stale Issues or PRs that are inactive but not considered stale P2 We'll consider working on this in future. (Assignee optional) team-Local-Exec Issues and PRs for the Execution (Local) team type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make --modify_execution_info additive sitaktif/bazel
4 participants
@brentleyjones @jin @meisterT @iancha1992