Skip to content

Commit

Permalink
Add -fno-canonical-system-headers to CROSSTOOL files so that gcc does…
Browse files Browse the repository at this point in the history
…n't resolve symlinks in .d files, which would confuse Blaze.

Fixes #714.

--
MOS_MIGRATED_REVID=111583801
  • Loading branch information
lberki authored and philwo committed Jan 7, 2016
1 parent 727d51a commit 763f139
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ private CToolchain.Builder createAarch64Toolchain() {
.addCompilerFlag("-funwind-tables")
.addCompilerFlag("-fstack-protector-strong")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-no-canonical-prefixes")
Expand Down Expand Up @@ -158,6 +159,7 @@ private CToolchain.Builder createAarch64ClangToolchain(String clangVersion) {
.addCompilerFlag("-Wno-invalid-command-line-argument")
.addCompilerFlag("-Wno-unused-command-line-argument")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-gcc-toolchain")
Expand Down Expand Up @@ -259,6 +261,7 @@ private CToolchain.Builder createBaseArmeabiToolchain(
.addCompilerFlag("-ffunction-sections")
.addCompilerFlag("-funwind-tables")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-no-canonical-prefixes");
Expand Down Expand Up @@ -394,6 +397,7 @@ private CToolchain.Builder createBaseArmeabiClangToolchain(String clangVersion,
.addCompilerFlag("-Wno-invalid-command-line-argument")
.addCompilerFlag("-Wno-unused-command-line-argument")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")
.addCompilerFlag("-fno-integrated-as")

// Linker flags
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ private CToolchain.Builder createBaseMipsToolchain() {
.addCompilerFlag("-frerun-cse-after-loop")
.addCompilerFlag("-frename-registers")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-no-canonical-prefixes")
Expand Down Expand Up @@ -204,6 +205,7 @@ private CToolchain.Builder createBaseMipsClangToolchain(
.addCompilerFlag("-Wno-invalid-command-line-argument")
.addCompilerFlag("-Wno-unused-command-line-argument")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-gcc-toolchain")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ private CToolchain.Builder createBaseX86Toolchain() {
.addCompilerFlag("-ffunction-sections")
.addCompilerFlag("-funwind-tables")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-no-canonical-prefixes")
Expand Down Expand Up @@ -191,6 +192,7 @@ private CToolchain.Builder createBaseX86ClangToolchain(
.addCompilerFlag("-Wno-invalid-command-line-argument")
.addCompilerFlag("-Wno-unused-command-line-argument")
.addCompilerFlag("-no-canonical-prefixes")
.addCompilerFlag("-fno-canonical-system-headers")

// Linker flags
.addLinkerFlag("-gcc-toolchain")
Expand Down
3 changes: 3 additions & 0 deletions tools/cpp/CROSSTOOL
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ toolchain {

# Anticipated future default.
unfiltered_cxx_flag: "-no-canonical-prefixes"
unfiltered_cxx_flag: "-fno-canonical-system-headers"

# Make C++ compilation deterministic. Use linkstamping instead of these
# compiler symbols.
Expand Down Expand Up @@ -220,6 +221,7 @@ toolchain {

# Anticipated future default.
unfiltered_cxx_flag: "-no-canonical-prefixes"

# Make C++ compilation deterministic. Use linkstamping instead of these
# compiler symbols.
unfiltered_cxx_flag: "-Wno-builtin-macro-redefined"
Expand Down Expand Up @@ -323,6 +325,7 @@ toolchain {

# Anticipated future default.
unfiltered_cxx_flag: "-no-canonical-prefixes"
unfiltered_cxx_flag: "-fno-canonical-system-headers"

# Make C++ compilation deterministic. Use linkstamping instead of these
# compiler symbols.
Expand Down

0 comments on commit 763f139

Please sign in to comment.