Skip to content

Commit

Permalink
Automated rollback of commit d6eb5de.
Browse files Browse the repository at this point in the history
RELNOTES: None.

*** Reason for rollback ***

Likely cause of b/121270139

*** Original change description ***

Increase visibility on node methods for internal use cases.

PiperOrigin-RevId: 227062533
  • Loading branch information
Googler authored and Copybara-Service committed Dec 27, 2018
1 parent fbe7d03 commit 331796f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public final void unmarkNeedsRebuilding() {
* <p>Changes in direct deps do <i>not</i> force this to return false. Only the value is
* considered.
*/
public final boolean unchangedFromLastBuild(SkyValue newValue) throws InterruptedException {
final boolean unchangedFromLastBuild(SkyValue newValue) throws InterruptedException {
checkFinishedBuildingWhenAboutToSetValue();
return !(newValue instanceof NotComparableSkyValue) && getLastBuildValue().equals(newValue);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ public synchronized Set<SkyKey> setValue(
* <p>Implementations need not check whether the value has changed - this will only be called if
* the value has not changed.
*/
public boolean isEligibleForChangePruningOnUnchangedValue() {
protected boolean isEligibleForChangePruningOnUnchangedValue() {
return true;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ public void ineligibleForPruning() throws InterruptedException {
NodeEntry entry =
new InMemoryNodeEntry() {
@Override
public boolean isEligibleForChangePruningOnUnchangedValue() {
protected boolean isEligibleForChangePruningOnUnchangedValue() {
return false;
}
};
Expand Down

0 comments on commit 331796f

Please sign in to comment.